-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components: Remove wp-g2 from scrollable #31207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Components
/packages/components
[Feature] Component System
WordPress component system
labels
Apr 26, 2021
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
April 26, 2021 18:36
Size Change: +32 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 27, 2021
sarayourfriend
force-pushed
the
remove/wp-g2-scrollable
branch
from
April 27, 2021 12:23
3575cef
to
a870f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Component System
WordPress component system
[Package] Components
/packages/components
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove wp-g2 imports from scollable as according to plan in #30503.
Removes the imports and adds new config values.
This will clash with #31209
How has this been tested?
Run Storybook (
npm run storybook:dev
) then go to:/?path=/story/g2-components-experimental-scrollable--default
Types of changes
Removal of wp-g2 imports.
Checklist:
*.native.js
files for terms that need renaming or removal).