components: Use vanilla emotion for view
#31099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +669 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Note, this PR is currently in a broken state, i'm not sure how to fix it as of right now but am brainstorming ideas. The core of the problem is that by not importing from |
sarayourfriend
force-pushed
the
add/vanilla-emotion-view
branch
from
bebfefb to
9293fdd
Compare
youknowriad
approved these changes
Apr 26, 2021
sarayourfriend
force-pushed
the
add/vanilla-emotion-view
branch
from
978b236 to
ee26897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use vanilla emotion for the base
Viewcomponent... as well as a whole slew of other updates that are necessary to makae this initial PR to migrate to vanilla emotion work.I'm sorry for the size of this PR. I tried to split it up but it seems impossible, there are either various build failures or tests that won't pass without all of these changes. I wish I could summarize the changes somehow but honestly it followed the process of starting with the smallest change and then following every rabbit hole that opened up until no more rabbit holes existed. I've essentially played whack-a-mole and whacked all the moles 😭
I'd be happy to walk anyone though this PR and the progression of it. Hopefully the commits help a little bit with that, but some of them aren't split up nicely at all.
Even with all these changes, there's still a lot to do. This leaves certain components like
surfacecompletely broken, but it's also unused so I think this is safe to do.How has this been tested?
Run
npm run storybook:devand ensure that G2 components continue to work, especially thinks like Text and Flex which usecreateComponentas these depend directly onView.Also the tests and build should pass.
Types of changes
New feature?
Checklist:
*.native.jsfiles for terms that need renaming or removal).