From 340ceb49bc3ad5383f7bbf81947091bb5a9d9873 Mon Sep 17 00:00:00 2001 From: Paul Von Schrottky Date: Wed, 7 Apr 2021 17:58:59 -0400 Subject: [PATCH 1/3] Remove unnecessary space in HTML tags The rich-text component was adding a space to the opening root tag of HTML before passing it to Aztec. I don't think this resulted in any bugs, so this change is more of a code clean-up. --- packages/rich-text/src/component/index.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rich-text/src/component/index.native.js b/packages/rich-text/src/component/index.native.js index ac83e09cec485b..45bd2c5b886144 100644 --- a/packages/rich-text/src/component/index.native.js +++ b/packages/rich-text/src/component/index.native.js @@ -836,7 +836,7 @@ export class RichText extends Component { extraAttributes += ` start=${ this.props.start }`; } } - value = `<${ tagName } ${ extraAttributes }>${ value }`; + value = `<${ tagName }${ extraAttributes }>${ value }`; } return value; } From 3f09863c941f6de8fde1dbdb16bae1003ad99454 Mon Sep 17 00:00:00 2001 From: Paul Von Schrottky Date: Wed, 7 Apr 2021 18:46:04 -0400 Subject: [PATCH 2/3] Updated search snapshot tests --- .../search/test/__snapshots__/edit.native.js.snap | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/block-library/src/search/test/__snapshots__/edit.native.js.snap b/packages/block-library/src/search/test/__snapshots__/edit.native.js.snap index f181950bc874b7..23c8c9faf38393 100644 --- a/packages/block-library/src/search/test/__snapshots__/edit.native.js.snap +++ b/packages/block-library/src/search/test/__snapshots__/edit.native.js.snap @@ -57,7 +57,7 @@ exports[`Search Block renders block with button inside option 1`] = ` "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

Search

", + "text": "

Search

", } } triggerKeyCodes={Array []} @@ -154,7 +154,7 @@ exports[`Search Block renders block with button inside option 1`] = ` "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

Search Button

", + "text": "

Search Button

", } } textAlign="center" @@ -224,7 +224,7 @@ exports[`Search Block renders block with icon button option matches snapshot 1`] "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

Search

", + "text": "

Search

", } } triggerKeyCodes={Array []} @@ -371,7 +371,7 @@ exports[`Search Block renders block with label hidden matches snapshot 1`] = ` "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

Search Button

", + "text": "

Search Button

", } } textAlign="center" @@ -441,7 +441,7 @@ exports[`Search Block renders with default configuration matches snapshot 1`] = "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

Search

", + "text": "

Search

", } } triggerKeyCodes={Array []} @@ -538,7 +538,7 @@ exports[`Search Block renders with default configuration matches snapshot 1`] = "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

Search Button

", + "text": "

Search Button

", } } textAlign="center" @@ -608,7 +608,7 @@ exports[`Search Block renders with no-button option matches snapshot 1`] = ` "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

Search

", + "text": "

Search

", } } triggerKeyCodes={Array []} From 43b3e8ab50ec2a4cbea0715b032cb174da169114 Mon Sep 17 00:00:00 2001 From: Paul Von Schrottky Date: Wed, 7 Apr 2021 18:47:53 -0400 Subject: [PATCH 3/3] Updated file block snapshot tests --- .../src/file/test/__snapshots__/edit.native.js.snap | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/block-library/src/file/test/__snapshots__/edit.native.js.snap b/packages/block-library/src/file/test/__snapshots__/edit.native.js.snap index ceb74a27f74922..c762a7299bfa9b 100644 --- a/packages/block-library/src/file/test/__snapshots__/edit.native.js.snap +++ b/packages/block-library/src/file/test/__snapshots__/edit.native.js.snap @@ -95,7 +95,7 @@ exports[`File block renders file error state without crashing 1`] = ` "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

File name

", + "text": "

File name

", } } textAlign="left" @@ -187,7 +187,7 @@ exports[`File block renders file error state without crashing 1`] = ` "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

Download

", + "text": "

Download

", } } textAlign="center" @@ -294,7 +294,7 @@ exports[`File block renders file without crashing 1`] = ` "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

File name

", + "text": "

File name

", } } textAlign="left" @@ -368,7 +368,7 @@ exports[`File block renders file without crashing 1`] = ` "eventCount": undefined, "linkTextColor": undefined, "selection": null, - "text": "

Download

", + "text": "

Download

", } } textAlign="center"