Block Library - Navigation: Fix arrow inheritance, polish #30287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +263 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
fix/arrow-color-inheritance
branch
from
18448d9 to
6aa8e28
Compare
This was referenced Mar 29, 2021
draganescu
approved these changes
Mar 29, 2021
ntsekouras
added
[Type] Bug
gziolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a few things. It fixes a small regression where increased specificity of styles meant the submenu was now again overlapped by the sibling inserter. Before:
After:
It fixes an issue with a hardcoded color in the chevron SVG, which meant colors weren't inherited:
After:
It changes it so that the border on submenus is only present if you haven't defined a color. I would expect future customization options on submenu borders, (see also #29963).
It removes a left value from the submenu, which meant text did not align vertically:
How has this been tested?
Please test a navigation menu with submenus, ideally including also a page list and a bunch of pages / subpages published on your site.
Please also verify this doesn't regress anything in the navigation screen.
Checklist:
*.native.jsfiles for terms that need renaming or removal).