Load block editor assets in the navigation and widget editors #30076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
kevin940726,
noisysocks,
draganescu,
grzim and
jasmussen
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
Thanks for flagging it. I don't think there will be a conflict. I do wonder whether 'wp-reset-editor-styles' will be something the nav or widget editors will need. I'll try testing the two together. |
talldan
deleted the
fix/enqueue-block-editor-assets-on-widget-and-nav-screens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21648
Fixes #28874
The
do_action( 'enqueue_block_editor_assets' );was not being called in the widget and navigation editors.This caused a side effect where
style.scssstyles for blocks were not displayed on those screens when the TT1-blocks theme was active.Additionally, the navigation editor now also uses the
should_load_block_editor_scripts_and_stylesfilter appropriately. This triggers some logic in core that enqueueswp-block-librarystyles and callsdo_action( 'enqueue_block_assets' ), a slightly different action.How has this been tested?
Test TT1 blocks
Test enqueueing
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: