Packages: Update the publishing command for npm with next dist tag #29379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
npm Packages
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
sirreal
reviewed
Mar 1, 2021
There was a problem hiding this comment.
Minor: Did you try combining --canary --dist-tag next?
A question: Do we get anything from having the sha in the version? It looks like that makes the trailing number completely redundant because I'd never expect to have multiple versions from a single sha, i.e. we may have 2.14.4-next.645224df70.0 but never 2.14.4-next.645224df70.1.
A concern: We'd like to have a nice sequence of "next" releases: 2.14.4-next.0, 2.14.4-next.1, etc. With the sha in the middle, it seems like we'll lost this sequencing and not really know the sequence of next builds. Humans can see it, but will semver understand that e.g. 2.14.4-next.abc.1 is newer than 2.14.4-next.fff.1?
Yes, it would solve the issue with the dist tag, but not the bug that Lerna has as described in the description:
You can see the issue when comparing the version published with
vs with the new approach:
In fact, in the
The issue is that we are always synchronizing
Yes, we do, but if we use
|
sirreal
approved these changes
Mar 1, 2021
|
I'm happy to iterate if there is a simpler solution to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried publishing to npm with the
nextdist tag earlier today as documented on WordPress Slack:https://wordpress.slack.com/archives/C5UNMSU4R/p1614334180022200
However, there were two issues discovered:
canarydist tag rather thannext--canaryin Lerna is buggy, it doesn’t take into account the most recen version inpackage.json, so versions might be outdated when they change in the release branch, related Lerna issue: lerna publish --canary yields unpredicted version number lerna/lerna#2622The revised approach takes a bit different approach:
nexttag is used for publishing--canaryflag it runslerna versionwith the dist id composed of the wordnextand the "sha" of the latest commitExample versions published:
Online Semver checker seems to be mildly satisfied:
How has this been tested?
I executed:
./bin/commander.js npm-nextIn theory, it should be possible to run this command again since it syncs
wp/nextwithrelease/10.1and adds two commits so there always is a new "sha" created. It's a bit impractical though as it will update over 40package.jsonfiles that changed between releases, so it will trigger publishing for all those packages creating git tag for each of them.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: