Theme JSON: Add border radius to the theme styles schema #27791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
Global Styles
aaronrobertshaw
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz,
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +5 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
This is looking good. However I think it would be good to show the default theme.json value in the sidebar here: |
|
The direction for this has changed for the time being. Until the new sidebar controls & component system lands, the preferred approach is to allow this sort of functionality via theme.json and attributes only, avoiding adding new panels or controls to the editor sidebar. This PR has been updated to opt-out of This approach should still allow for themes and patterns to provide border radii. |
This was referenced Dec 23, 2020
aaronrobertshaw
force-pushed
the
update/border-radius-support-theme-json
branch
from
e35cb5c to
806f210
Compare
oandregal
approved these changes
Dec 24, 2020
|
I've also noticed that we have a border-radius control for the button block. As a follow-up to this PR it'd be nice to migrate the button block to use the hook instead. |
Thanks for the review 👍
I'm in the process of adding this border radius support to a few blocks (group, image & search), I'll include a PR for switching the buttons block to use the new hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Manually.
experimental-default-theme.jsonwith a new block context adding a style for border radius.wp-block-groupCSS classScreenshots
Editor:
Frontend:
Types of changes
Bug fix
Checklist: