Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile Release v1.38.1 #26034

Closed
wants to merge 13 commits into from
Closed

Mobile Release v1.38.1 #26034

wants to merge 13 commits into from

Conversation

ceyhun
Copy link
Member

@ceyhun ceyhun commented Oct 12, 2020 •
edited
Loading

Description

Release 1.38.1 of the react-native-editor and Gutenberg-Mobile.

For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#2711

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ceyhun ceyhun added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Oct 12, 2020
@ceyhun ceyhun mentioned this pull request Oct 12, 2020
Merged
5 tasks
@ceyhun ceyhun requested a review from cameronvoell October 12, 2020 18:40
@ceyhun ceyhun marked this pull request as ready for review October 12, 2020 18:40
cameronvoell
cameronvoell approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and all fixes are working for me. :shipit:

@ceyhun
Copy link
Member Author

ceyhun commented Oct 16, 2020

Will merge these changes via #26064

@ceyhun ceyhun closed this Oct 16, 2020
@ceyhun ceyhun deleted the rnmobile/release_1.38.1 branch October 16, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceyhun @cameronvoell @lukewalczak @marecar3