Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/block icon component readme #24947

Merged
merged 6 commits into from
Sep 9, 2020
Merged

Add/block icon component readme #24947

merged 6 commits into from
Sep 9, 2020

Conversation

JustinyAhin
Copy link
Member

Description

Added documentation for the block icon component (see #22891)

How has this been tested?

N/A, documentation only

Types of changes

Documentation

Checklist:

  • [n/a] My code is tested.
  • [n/a] My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • [n/a] My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@JustinyAhin JustinyAhin marked this pull request as ready for review September 1, 2020 07:22
@JustinyAhin JustinyAhin added the [Type] Developer Documentation Documentation for developers label Sep 2, 2020
mkaz
mkaz approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thanks! 👍

@mkaz mkaz merged commit 0397f87 into WordPress:master Sep 9, 2020
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 9, 2020
@JustinyAhin JustinyAhin mentioned this pull request Sep 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinyAhin @mkaz