-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Support percentage in columns #23828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
lukewalczak
force-pushed
the
rnmobile/column-percentage
branch
from
July 10, 2020 11:49
bb1c6a8
to
239476a
Compare
lukewalczak
force-pushed
the
rnmobile/column-percentage
branch
from
July 10, 2020 12:32
239476a
to
9e03916
Compare
lukewalczak
force-pushed
the
rnmobile/column-percentage
branch
4 times, most recently
from
July 21, 2020 15:23
7a43e55
to
35338e3
Compare
lukewalczak
force-pushed
the
rnmobile/column-percentage
branch
from
July 24, 2020 09:09
35338e3
to
b11bee4
Compare
lukewalczak
force-pushed
the
rnmobile/column-percentage
branch
from
July 27, 2020 12:50
ce94d64
to
fbad1ac
Compare
lukewalczak
added
[Block] Columns
Affects the Columns Block
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
labels
Jul 27, 2020
dratwas
reviewed
Aug 5, 2020
packages/block-editor/src/components/block-variation-picker/index.native.js
Outdated
Show resolved
Hide resolved
dratwas
reviewed
Aug 5, 2020
dratwas
reviewed
Aug 5, 2020
dratwas
reviewed
Aug 5, 2020
dratwas
reviewed
Aug 5, 2020
dratwas
reviewed
Aug 5, 2020
packages/components/src/mobile/bottom-sheet/range-cell.native.js
Outdated
Show resolved
Hide resolved
lukewalczak
force-pushed
the
rnmobile/column-percentage
branch
from
August 7, 2020 13:54
8eb8bb9
to
249a71c
Compare
lukewalczak
force-pushed
the
rnmobile/column-percentage
branch
from
August 7, 2020 14:01
89596cc
to
c569bd2
Compare
dratwas
reviewed
Aug 7, 2020
dratwas
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Columns
Affects the Columns Block
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / first iteration of: wordpress-mobile/gutenberg-mobile#2197
Description
That PR introduces the first iteration of the column percentage mechanism. It includes:
How has this been tested?
Columns
block3. Expect to see bottom sheet with layout picker
33/33/33
90
8. Expect that fill level in the preview (to the left of a slider) increased
55.555555
and pressDone
13. Expect to have value with 1 decimal
15. Expect that first column has width equal
90
and the second55.5
17. Expect to see columns displayed proportionally to set the width values
Screenshots
Types of changes
New feature/functionality - columns percentage
Checklist: