Image block: allow uploading external image if image host allows it #23565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Enhancement
|
Size Change: +214 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ellatrix
commented
Jun 29, 2020
ellatrix
changed the title
ellatrix
force-pushed
the
try/upload-external-image
branch
from
35d4528 to
0e027ff
Compare
ellatrix
force-pushed
the
try/upload-external-image
branch
from
0e027ff to
0db02ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #2515 (partial fix).
This is a pretty simple change to allow the user to upload an external (hot linked) image. External images may be international, but may also be the result of paste (such as from Google Docs). Currently, we don't offer the user an option to upload these images (from the Google CDN for example). There's a risk that these images may disappear.
Ideally, from paste, we never insert external image URLs and upload them instead, but this would mean that paste is async and will mess with undo levels. This problem has to be fixed first.
The button only works if the host allows cross origin resource sharing. Google Docs and the Google CDN allows it, so does Cloudup and services like that. It usually won't work when trying to upload images from normal sites after paste.
In the future, we can try to make this automatic.
How has this been tested?
Create a Google Doc and upload an image. Copy paste to Gutenberg. You'll see an image, but it's external. Upload the image with the new button. You can now also edit the image. :)
Screenshots
Types of changes
Checklist: