Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile]Fix layout issue in Shortcode #20097

Merged
merged 2 commits into from
Feb 10, 2020
Merged

[RNMobile]Fix layout issue in Shortcode #20097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67fb174
Remove workaround for autocomplete that was introducing layout issues
chipsnyder Feb 7, 2020
b8c691c
Merge remote-tracking branch 'upstream/master' into rnmobile/issue-18…
chipsnyder Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions packages/block-library/src/shortcode/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import { Platform, View, Text } from 'react-native';
import { View, Text } from 'react-native';

/**
* WordPress dependencies
Expand Down Expand Up @@ -53,14 +53,6 @@ export function ShortcodeEdit( props ) {
onBlur={ onBlur }
autoCorrect={ false }
autoComplete="off"
/*
* For some devices autoCorrect and autoComplete are not enough to hide the suggestion toolbar.
* Following the suggestion below we added the keyboard type as well.
* https://stackoverflow.com/questions/37001070/how-to-avoid-the-suggestions-of-keyboard-for-android-in-react-native/51411575#51411575
*/
keyboardType={
Platform.OS === 'ios' ? 'default' : 'visible-password'
}
placeholderTextColor={ placeholderStyle.color }
/>
</View>
Expand Down