diff --git a/packages/block-library/src/video/edit.js b/packages/block-library/src/video/edit.js index 05f7b2bc1b9d4e..5dbc2945b363fa 100644 --- a/packages/block-library/src/video/edit.js +++ b/packages/block-library/src/video/edit.js @@ -7,7 +7,6 @@ import { Button, Disabled, PanelBody, - ToolbarGroup, withNotices, } from '@wordpress/components'; import { @@ -17,6 +16,7 @@ import { MediaPlaceholder, MediaUpload, MediaUploadCheck, + MediaReplaceFlow, RichText, } from '@wordpress/block-editor'; import { Component, createRef } from '@wordpress/element'; @@ -45,12 +45,6 @@ const VIDEO_POSTER_ALLOWED_MEDIA_TYPES = [ 'image' ]; class VideoEdit extends Component { constructor() { super( ...arguments ); - // edit component has its own src in the state so it can be edited - // without setting the actual value outside of the edit UI - this.state = { - editing: ! this.props.attributes.src, - }; - this.videoPlayer = createRef(); this.posterImageButton = createRef(); this.onSelectURL = this.onSelectURL.bind( this ); @@ -76,7 +70,6 @@ class VideoEdit extends Component { setAttributes( { src: url } ); }, onError: ( message ) => { - this.setState( { editing: true } ); noticeOperations.createErrorNotice( message ); }, allowedTypes: ALLOWED_MEDIA_TYPES, @@ -95,8 +88,6 @@ class VideoEdit extends Component { const { attributes, setAttributes } = this.props; const { src } = attributes; - // Set the block's src from the edit component's state, and switch off - // the editing UI. if ( newSrc !== src ) { // Check if there's an embed block that handles this URL. const embedBlock = createUpgradedEmbedBlock( @@ -108,8 +99,6 @@ class VideoEdit extends Component { } setAttributes( { src: newSrc, id: undefined } ); } - - this.setState( { editing: false } ); } onSelectPoster( image ) { @@ -146,25 +135,20 @@ class VideoEdit extends Component { attributes, setAttributes, } = this.props; - const { editing } = this.state; - const switchToEditing = () => { - this.setState( { editing: true } ); - }; const onSelectVideo = ( media ) => { if ( ! media || ! media.url ) { - // in this case there was an error and we should continue in the editing state - // previous attributes should be removed because they may be temporary blob urls + // in this case there was an error + // previous attributes should be removed + // because they may be temporary blob urls setAttributes( { src: undefined, id: undefined } ); - switchToEditing(); return; } // sets the block's attribute and updates the edit component from the - // selected media, then switches off the editing UI + // selected media setAttributes( { src: media.url, id: media.id } ); - this.setState( { src: media.url, editing: false } ); }; - if ( editing ) { + if ( ! src ) { return ( } @@ -184,14 +168,14 @@ class VideoEdit extends Component { return ( <> - -