Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show new block indicator in default appender too #18289

Merged

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Nov 5, 2019

Description

Showing the "ADD BLOCK HERE" block insertion point indicator when the block list is fully empty too. Also, at the end of the list when not empty

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1542

How has this been tested?

Using the gutenberg-mobile PR.

Types of changes

  1. Revised the default mobile block appender to show the new-block insertion point indicator instead of the default paragraph block, when the related flag is true and the block list is empty.
  2. Introduced a method to check if the indicator at the end of the block should appear, when the insertion point is at the end of the list.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@hypest hypest added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 5, 2019
@hypest hypest added this to the Future milestone Nov 5, 2019
@hypest hypest requested a review from mchowning November 5, 2019 15:16
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! I really like the explanatory comments you added. 🎉

@hypest hypest merged commit 59da6ed into master Nov 6, 2019
@hypest hypest deleted the rnmobile/show-new-block-indicator-in-default-appender branch November 6, 2019 16:39
@youknowriad youknowriad modified the milestones: Future, Gutenberg 6.9 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants