Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I came across an issue trying to commit for the first time at contributor day. Further up in my file tree I have a folder name with a space in it.
npm install
seemed to run fine, but when I tried to commit, thedocs:build
process was not able to run as it could not find the proper file path. Where the file path is created, this PR replaces the space with an escaped space.CC: @aduth - thanks for your help with this!
How has this been tested?
Gutenberg plugin cloned and installed with a space in the path prior to the WordPress instance. My file path was
/Users/mmarzeotti/Local Sites/contribute/app/public/wp-content/plugins/gutenberg/docs/tool/update-data.js
for reference. Runnpm run docs:build
and it will be unable to find the files necessary to run. When spaces are escaped, the command runs as it should.Types of changes
The same change (replace space with escaped space) is made in two places referencing
docgen
.Checklist: