Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sentence case for tooltips #17336

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Use sentence case for tooltips #17336

merged 3 commits into from
Sep 13, 2019

Conversation

mapk
Copy link
Contributor

@mapk mapk commented Sep 4, 2019

Description

Fixes #16764 in part. I believe I've found all the tooltip instances that used title case and switched them to sentence case. I have not changed the labels in the popovers yet. I'm thinking that could be another PR to keep things simple. I'm starting to fiddle with a lot of files and it feel uncomfortable.

cc: @gziolo, I'd love to get your eyes on this to make sure I edited the correct files. If there are others I need to edit, let me know.

How has this been tested?

Locally.

Screenshots

Before:

61936717-95ccfe80-af8d-11e9-8fb0-c167ab258eb3

After:

Screen Shot 2019-09-04 at 4 14 21 PM

Types of changes

Non-breaking change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@mapk mapk added General Interface Parts of the UI which don't fall neatly under other labels. Needs Testing Needs further testing to be confirmed. labels Sep 4, 2019
@mapk mapk self-assigned this Sep 4, 2019
@gziolo
Copy link
Member

gziolo commented Sep 9, 2019

Nice, some tests need to be updated as they apparently depend on those labels :)

@mapk
Copy link
Contributor Author

mapk commented Sep 9, 2019

Looks like @senadir updated some snapshots for me! Thanks! 💯

@gziolo I'm not sure how to correct the tests that need updating. Is this something you can guide me through?

@senadir
Copy link
Contributor

senadir commented Sep 9, 2019

test still fails for some reason, Ithough I fixed all the outstanding issues, seems new ones showed up, I will restart the tests and see

as for finding the issues, you can go to the failed test building the "Details" link on right on the Travis check and then opening the failed job (ignore jobs that are allowed to fail)

you will have a long log, the failed checks are the ones that start with FAIL beside it, you will find the corresponding file to test, like

FAIL packages/e2e-tests/specs/adding-inline-tokens.test.js 
FAIL packages/e2e-tests/specs/block-transforms.test.js

Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid update, and it looks like the tests are now passing. Thanks, @mapk and @senadir!

@senadir senadir merged commit 1e2e08d into master Sep 13, 2019
@senadir senadir deleted the update/sentence-case-labels branch September 13, 2019 14:11
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy: Inconsistent capitalization of labels in tooltips and dropdown menus
5 participants