Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format Library: Remove secondary (access) shortcuts #15191

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Format Library: Remove secondary (access) shortcuts #15191

merged 3 commits into from
Jun 7, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Apr 25, 2019 •
edited
Loading

Description

See #11154 (partial fix). Removes all access shortcuts from the format library.

It is worth noting that:

  • All primary (most used) formats (bold, italic, and link) still have primary shortcuts.
  • Strikethrough and code are present in the UI, so they can both be accessed with the keyboard and pointer device.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Format library /packages/format-library labels Apr 25, 2019
@ellatrix ellatrix added this to the 5.6 (Gutenberg) milestone Apr 25, 2019
@ellatrix ellatrix requested a review from afercia April 25, 2019 17:51
@ellatrix ellatrix force-pushed the remove/secondary-format-shortcuts branch from be3116d to 9ec26f6 Compare May 1, 2019 11:16
jorgefilipecosta
jorgefilipecosta approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me from the code point of view 👍

@gziolo gziolo removed this from the 5.6 (Gutenberg) milestone May 6, 2019
@gziolo
Copy link
Member

gziolo commented May 23, 2019

This PR needs rebase and should be merged afterward :)

@ellatrix ellatrix force-pushed the remove/secondary-format-shortcuts branch from 9ec26f6 to 7320056 Compare June 6, 2019 17:56
@ellatrix ellatrix merged commit 2d66c59 into master Jun 7, 2019
@ellatrix ellatrix deleted the remove/secondary-format-shortcuts branch June 7, 2019 07:06
@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@afercia afercia Awaiting requested review from afercia

@aduth aduth Awaiting requested review from aduth

@youknowriad youknowriad Awaiting requested review from youknowriad

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Format library /packages/format-library
Projects
None yet
Milestone
Gutenberg 5.9
Development

Successfully merging this pull request may close these issues.
4 participants
@ellatrix @gziolo @jorgefilipecosta @youknowriad