Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ref as innerRef in PostTile #14018

Closed
wants to merge 10 commits into from
Closed

Rename ref as innerRef in PostTile #14018

wants to merge 10 commits into from

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Feb 21, 2019

Description

Seems like ref is reserved or sth it doesn't work so we are changing this.

How has this been tested?

With parent PR wordpress-mobile/gutenberg-mobile#622

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

noisysocks and others added 10 commits February 18, 2019 12:44
* RichText: only ignore input types that insert HTML

* Mark RichTextInputEvent as unstable

* Use Set
…eters returned onChange, and we forgot to update the PostTitle component (#13967)
Upload media progress bar is missing while media is uploading new
* Trigger onFocusStatusChange from PostTitle

* Fix lint issue

* Update post title shadow mechanism

Also open inner ref so that focus state can be updated when focus is made programmatically

* Update props

* Update onRef as ref

* Update title padding&margin
@pinarol pinarol added the Mobile Web Viewport sizes for mobile and tablet devices label Feb 21, 2019
@pinarol pinarol self-assigned this Feb 21, 2019
@pinarol pinarol requested a review from etoledom February 21, 2019 16:15
@pinarol pinarol closed this Feb 21, 2019
@pinarol pinarol deleted the rnmobile/rename-ref branch February 21, 2019 17:14
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) and removed Mobile Web Viewport sizes for mobile and tablet devices labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants