Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Implementing Clear All Settings button on Image Settings #13753

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Mobile: Implementing Clear All Settings button on Image Settings #13753

merged 4 commits into from
Feb 12, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Feb 7, 2019 •
edited
Loading

Description

This is a small PR that implements the functionality of the Revert to Original Clear All Settings button.
As discussed with Thomas, this button should revert all the editable attributes to their default as when the block is created.

clear-settings

To test:

  • Check out the related gutenberg-mobile branch and run the app.
  • Add an image block and add an image to it.
  • Open the image settings.
  • Edit Alt and Link-to.
  • Close the BottomSheet.
  • Open the image settings again.
  • Press Revert to Original.
  • Check that Alt and Link-to are cleared.
    • The BottomSheet should not dismiss automatically.

@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 7, 2019
@etoledom etoledom self-assigned this Feb 7, 2019
@etoledom etoledom requested a review from marecar3 February 7, 2019 21:40
This was referenced Feb 7, 2019
Merged
Closed
@etoledom etoledom removed the request for review from marecar3 February 11, 2019 08:40
@etoledom etoledom changed the title Mobile: Implementing Reset to Original button on Image Settings Mobile: Implementing Clear All Settings button on Image Settings Feb 11, 2019
hypest
hypest approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etoledom
Copy link
Contributor Author

Thank you!

@etoledom etoledom merged commit ba38d23 into master Feb 12, 2019
@etoledom etoledom deleted the rnmobile/image-settings-revert-button branch February 12, 2019 13:58
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 15, 2019
This was referenced Feb 18, 2019
Merged
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@etoledom @youknowriad
Mobile: Implementing Clear All Settings button on Image Settings (#…
8993093 
…13753)

* Mobile: Implementing `Reset to Original` button on Image Settings

* Mobile: Change `Revert to Origin` button title to 'Clear All Settings'

* Mobile Image block: Changed method name to `onClearSettings` for clarity
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@etoledom @youknowriad
Mobile: Implementing Clear All Settings button on Image Settings (#…
6bbd8c2 
…13753)

* Mobile: Implementing `Reset to Original` button on Image Settings

* Mobile: Change `Revert to Origin` button title to 'Clear All Settings'

* Mobile Image block: Changed method name to `onClearSettings` for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@etoledom etoledom

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.1 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@etoledom @hypest @youknowriad