Fix: Categories Block: hierarchical Dropdown #13567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
gziolo
reviewed
Jan 30, 2019
| @@ -116,7 +116,11 @@ class CategoriesEdit extends Component { | |||
| { __( 'Categories' ) } | |||
| </label> | |||
| <select id={ selectId } className="wp-block-categories__dropdown"> | |||
| { categories.map( ( category ) => this.renderCategoryDropdownItem( category, 0 ) ) } | |||
| { categories.map( ( category ) => { | |||
There was a problem hiding this comment.
This is the case where you can also use more functional approach and combine filter and map:
{ categories.filter( ( { parent } ) => parent === 0 ).map( ( category ) => this.renderCategoryDropdownItem( category, 0 ) ) }Still the same code, just coded differently and I haven't tested :)
There was a problem hiding this comment.
Hi @gziolo, I applied the refactor to use a functional code style. Thank you for your suggestion!
jorgefilipecosta
force-pushed
the
fix/categories-block-hierarchical-Dropdown
branch
from
ca7ffb5 to
2853d14
Compare
gziolo
reviewed
Jan 30, 2019
| @@ -116,7 +116,13 @@ class CategoriesEdit extends Component { | |||
| { __( 'Categories' ) } | |||
| </label> | |||
| <select id={ selectId } className="wp-block-categories__dropdown"> | |||
| { categories.map( ( category ) => this.renderCategoryDropdownItem( category, 0 ) ) } | |||
| { categories.filter( | |||
There was a problem hiding this comment.
This made me think we could filter inside getCategories method to make it easier to follow here.
I will test this PR by tomorrow.
There was a problem hiding this comment.
I made a new check in the logic of the code and it looks like the filtering was already being accounted in the logic. The existing logic only had a bug when accessing a prop that caused the filtering to not be performed. The fix was simplified.
There was a problem hiding this comment.
This is nice, thanks for investigating further, testing your changes soon.
jorgefilipecosta
force-pushed
the
fix/categories-block-hierarchical-Dropdown
branch
from
2853d14 to
c0de3c2
Compare
gziolo
approved these changes
Jan 31, 2019
jorgefilipecosta
deleted the
fix/categories-block-hierarchical-Dropdown
branch
|
Thank you for the reviews @gziolo! |
daniloercoli
added a commit
that referenced
this pull request
Feb 1, 2019
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: Try alternate list item jump fix. (#12941) Mobile bottom sheet component (#13612) Remove unintentional right-margin on last odd-item. (#12199) Introduce left and right float alignment options to latest posts block (#8814) Fix Google Docs table paste (#13543) Increase bottom padding on gallery image caption (#13623) Fix the editor save keyboard shortcut not working in code editor view (#13159) Plugin: Deprecate gutenberg_add_admin_body_class (#13572) Rnmobile/upload media failed state (#13615) Make clickOnMoreMenuItem not dependent on aria labels (#13166) Add: className prop support to server side render. (#13568) Fix: Categories Block: hierarchical Dropdown (#13567) Docs: Add clarification about git workflow (#13534) Plugin: Remove `user_can_richedit` filtering (#13608) eslint-plugin: Add rule `no-unused-vars-before-return` (#12828) Image settings button (#13597) Fixed wording for the color picker saturation (#13479) # Conflicts: # packages/block-library/src/image/edit.native.js
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Previously higher than second levels categories here rendered multiple times on the categories block, when "Show Hierarchy" and "Display as Dropdown" options here true. This commit fixes that problem.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Previously higher than second levels categories here rendered multiple times on the categories block, when "Show Hierarchy" and "Display as Dropdown" options here true. This commit fixes that problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #13560
Previously higher than second levels categories here rendered multiple times on the categories block, when "Show Hierarchy" and "Display as Dropdown" options here true.
This PR fixes that problem.
How has this been tested?
I created a Level 1 category without parent category.
I created a Level 2 category child of Level 1.
I created a Level 3 category child of Level 2.
I added a post with a Level 3 category.
I added the Category block and enable "Show Hierarchy" and "Display as Dropdown".
I checked the dropdown as displayed as expected without Level 2 and Level 3 being repeated.
Screenshots
Before:
After: