Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Font size picker does not work on mobile #13257

Merged

Conversation

jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Jan 9, 2019

Description

Fixes: #13155
It had a z-index issue and the popover appeared below the sidebar.
This PR applies a fix to the z-index problem.

How has this been tested?

Verify that the font size picker appears correctly on mobile.

Screenshots

img_6637

@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended Mobile Web Viewport sizes for mobile and tablet devices [Package] Editor /packages/editor labels Jan 9, 2019
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, ship it!

@jorgefilipecosta jorgefilipecosta added this to the 4.9 (Gutenberg) milestone Jan 10, 2019
@jorgefilipecosta jorgefilipecosta merged commit 7f3b8c7 into master Jan 11, 2019
@jorgefilipecosta jorgefilipecosta deleted the fix/font-size-picker-does-not-work-on-mobile branch January 11, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile Web Viewport sizes for mobile and tablet devices [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paragraph: Font size selector does not work on mobile
2 participants