Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore displaying formatting shortcuts in toolbar #11104

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

ellatrix
Copy link
Member

Description

After #10209, shortcuts no longer display in the tooltips of the formatting toolbar. This branch adds extra props on ToolbarButton to display the wanted combination (there can be more than one, e.g. link).

How has this been tested?

Check the formatting buttons' tooltips.

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Oct 26, 2018
@ellatrix ellatrix added this to the 4.2 milestone Oct 26, 2018
@ellatrix ellatrix requested review from gziolo and a team October 26, 2018 11:16
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I haven't tested.

@ellatrix ellatrix merged commit 0a1d6e0 into master Oct 26, 2018
@ellatrix ellatrix deleted the fix/display-shortcuts branch October 26, 2018 11:40
@mtias mtias added the [Type] Regression Related to a regression in the latest release label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants