Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @wordpress/hooks README to include namespace mention #11061

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Update @wordpress/hooks README to include namespace mention #11061

merged 1 commit into from
Oct 26, 2018

Conversation

danielbachhuber
Copy link
Member

Usage of addAction() or addFilter() require the namespace as a second argument. This pull request updates the README.md accordingly.

@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers [Package] Hooks /packages/hooks labels Oct 25, 2018
@desrosj desrosj added this to the WordPress 5.0 milestone Oct 25, 2018
@danielbachhuber danielbachhuber modified the milestones: WordPress 5.0, 4.2 Oct 25, 2018
gziolo
gziolo approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. We discussed removing 2nd param several times but we didn't take any actions.

@gziolo gziolo merged commit 149baed into master Oct 26, 2018
@gziolo gziolo deleted the hooks-namespace-docs branch October 26, 2018 08:58
daniloercoli added a commit that referenced this pull request Oct 26, 2018
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
7659051 
…rnmobile/merge-blocks-on-backspace

* 'master' of https://github.com/WordPress/gutenberg:
  Do not add isDirty prop to DOM (#11093)
  Format API (#10209)
  Remove 4.2 deprecated features (#10952)
  Update `@wordpress/hooks` README to include namespace mention (#11061)
  Feature: save lock control via actions (#10649)
  Fix usage of `preg_quote()` (#10998)
  Update plugin version to 4.1.1 (#11078)
  Improve preloading request code (#11007)
  Fix dynamic blocks not rendering in the frontend (#11050)
  Media & Text: Fixing vertical alignment of the image (#11025)
  Date: Mark getSettings as experimental (#10636)
  Improve handling of centered 1-col galleries with small images (#11040)
  Use better help text for ALT text input; fixes #8391. (#11052)

# Conflicts:
#	packages/editor/src/components/rich-text/index.native.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees
No one assigned
Labels
[Package] Hooks /packages/hooks [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbachhuber @gziolo @desrosj