Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 4.1 deprecated features #10732

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Conversation

youknowriad
Copy link
Contributor

No description provided.

@youknowriad youknowriad self-assigned this Oct 18, 2018
@youknowriad youknowriad requested review from gziolo and a team October 18, 2018 12:07
@youknowriad youknowriad added this to the 4.1 - UI freeze milestone Oct 18, 2018
@gziolo
Copy link
Member

gziolo commented Oct 18, 2018

You need to run npm run docs:build to make Travis happy :)

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it after you deal with the Travis' bad mood :)

* @return {Object} Action object.
*/
export function checkTemplateValidity() {
// TODO: Hello future deprecation remover. Please ensure also to remove all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the TODO note was overlooked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always grep for version number :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team work 🥇

@youknowriad youknowriad force-pushed the update/remove-41-deprecations branch from e1be164 to 0e1a266 Compare October 18, 2018 12:24
@youknowriad youknowriad merged commit 7316f16 into master Oct 18, 2018
@youknowriad youknowriad deleted the update/remove-41-deprecations branch October 18, 2018 12:55
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants