Fix: z-index: -1 needed for publish footer due to accordions
#10589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nosolosw: |
tofumatt
requested review from
tofumatt and
oandregal
and removed request for
tofumatt
|
Nice catch! I merged the new date picker so I'll try to have a look, but if @nosolosw gets to it before me I trust them 😄 |
|
@postphotos Thanks for the bug report, ping, and proposal! I appreciate it. I think we may want an alternative way to fix this. Instead of hiding the pre-publish checks, we should make sure it sticks to the bottom, even when the parent grows. #10680 implements that approach. Closing this PR in favor of 10680. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In testing the new calendar feature (#7621) I spotted a bug. When using the new pre-publish toggle (#9760), opening longer panels cause a z-index issue as such:
The problem has to do with the way the accordions above behave, and a quick
z-index: -1gets it to cooperate again.How has this been tested?
I tested the fix replicated the bug in Safari, Firefox and Chrome. I was not able to test in Edge or Opera, so this would be nice if it's required for merge.
Screenshots
In addition to the bug was screenshot above, The bug and fix is seen here as a screen recording:
https://www.youtube.com/embed/M6CJtV1yFq4
Types of changes
Fixes a small regression oversight probably missed in #9670.
Checklist: