-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACF required fields cause a saving stall out with no notices #9699
Comments
Thank you for commenting and for including a screenshot! In the screenshot of the console errors you posted, the query string contains Here is a copy of the console errors from your screenshot for reference:
Your post mentioned ACF Pro 4.3.7, but is that your WordPress version? If yes, could you verify you have updated to the latest stable release of ACF Pro? (5.7.4 at the time of this writing) May I ask if you have also reported this problem at https://www.advancedcustomfields.com/support/ already? I tried searching and I did notice a similar-sounding problem was reported in that forum for ACF Pro 5.7.1 at https://support.advancedcustomfields.com/forums/topic/major-cant-publish-anything-ver-5-7-0-beta2/ that has one reply that says "Cant Publish/Update. Endless turning Arrow in WP Update Button" but I also saw that another person on that thread noted a console error that was different compared to the one you posted (which I am not sure yet is relevant or not). |
Also experiencing this issue. Can verify that this happens using Gutenberg, despite the Advanced Custom Fields PRO
|
Thank you for the extra info! @ramiroazar, to confirm, does the problem happen only when both ACF Pro and Gutenberg are installed? Or does the problem also happen if either one or the other of those is installed and activated separately? The goal for that question is to try to verify whether the problem is a result of a conflict with these two plugins as opposed to something else. I searched online to learn more about 500 errors and several of the articles (like this one) recommend checking the server error logs at the time the error occurs to get more information which may help pinpoint the problem. Is that something you are able to do? A 500 error indicates the server wasn't able to process a request of some kind, but it doesn't help show what may be causing the trouble. Seeing related server error logs may help narrow down the source of the conflict in this case. |
This error happens when publishing or updating a post using Gutenberg which contains empty required fields registered using Advanced Custom Fields PRO. Therefore, it does not manifest unless both plugins are installed and activated. Having checked the local server error logs, it seems nothing is getting logged relating to or resulting from this error. It may also be worth noting that I'm unable to replicate #9983. |
I've tested again using the following steps and am able to see the "Saving" indicator in an infinite loop when I try to update a post which has an empty required custom field made with the Advanced Custom Fields plugin.
Result: the post content does update for me though I can see the "Saving" indicator pulse indefinitely (the "Update" button looked fine in my test) and I see the following 500 error in the Network panel in devtools: Note: I used the free version of ACF and not the Pro version for testing. |
Is this still an issue? I know both ACF and Gutenberg have been updated to fix conflicts. |
Hello! I was able to resolve this issue by making my required fields not required, but it took some time to troubleshoot that. So putting this here to help someone else who is having the same problem.
Scenario:
WP Site running Gutenberg [3.7.0] and ACF Pro [4.3.7]
Installed in a subdirectory
The issue occurred on a custom post type, but I don't think that's relevant to the problem
Open an existing post, make an edit to any field, click 'update'. The update button goes into an infinite loop and looks like it is trying to save. But the 'post updated! view post' flag appears below, so it is unclear whether it worked or not. Check the front end or reload the backend and see that it did not update.
Turned out that there were custom fields set to "Required" that did not have data on the post in question because the requirement was added after the empty field had already been saved. So turning off the requirement resolved the issue.
This is unexpected behavior, there was no error notice near the required fields or other clues about what was wrong. It would be helpful to return an error message on the front end prompting the user to fill out the required fields.
These js errors were in the console:
The text was updated successfully, but these errors were encountered: