Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Select: Better sticky toolbar #951

Closed
jasmussen opened this issue May 31, 2017 · 3 comments
Closed

Multi Select: Better sticky toolbar #951

jasmussen opened this issue May 31, 2017 · 3 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels.

Comments

@jasmussen
Copy link
Contributor

From #896, multiple block selection is now in. When you select across blocks, you can delete them all at once with a trash can at the top.

That toolbar is only sticky to the first selected block, so it doesn't scroll with you down the page. There are some ideas on how to improve this here:

Regarding sticky positioning... We could wrap the selected block in an extra div. This would also be far cleaner than adding the buttons to the first selected block. A big downside is that iframes would reload. The other solution is adding the buttons to the parent division, but we'll have to reposition it with JS.

An alternative from here, is to add a new toolbar which overlays the Editor Bar entirely, and appears only when you select multiple blocks at the same time. The pattern to emulate could be that of Google Photos, where you have one toolbar when you don't have any photos selected:

photos

... and another toolbar replacing it, when you have photos selected:

photos selected

Might be nice to even copy the "8 blocks selected" pattern. This could even be the location of the mover buttons.

Here's a quick and dirty mockup of how that could look:

selecting across blocks

@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. labels May 31, 2017
@ellatrix
Copy link
Member

Thanks for reposting these @jasmussen!

@ellatrix
Copy link
Member

I love this BTW!!! This is what I mean in the previous ticket with iOS photos too. :)

@ellatrix
Copy link
Member

ellatrix commented Jun 3, 2017

Fixed in #955.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

No branches or pull requests

2 participants