-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashicon not loading properly in test environment when loaded from externals. #944
Comments
👀 |
I see it :| Probably caused by #929 somehow. What error are you getting here? |
Yeah it is caused by #929, but not to worry I think it can be resolved fairly easily. Here is the warning message.
Dashicon extends wp.element We need to add the externals into the test environment, the only hangup I have is figuring out how to use node externals and another library in the same configuration. Was curious if you know how to do that. |
Noting that this will be fixed by the current state of #935 (https://github.com/WordPress/gutenberg/pull/935/files#diff-512a8a050d031aaf7a1c47fb4f2a9656R10). |
closing as fixed |
The Dashicon is not loading properly in the test environment for a build. I think somehow wp.element is not being added in as an external which Dashicon requires to extend the component class.
The text was updated successfully, but these errors were encountered: