Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashicon not loading properly in test environment when loaded from externals. #944

Closed
BE-Webdesign opened this issue May 30, 2017 · 5 comments
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended

Comments

@BE-Webdesign
Copy link
Contributor

BE-Webdesign commented May 30, 2017

The Dashicon is not loading properly in the test environment for a build. I think somehow wp.element is not being added in as an external which Dashicon requires to extend the component class.

@BE-Webdesign BE-Webdesign added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended labels May 30, 2017
@BE-Webdesign
Copy link
Contributor Author

@nylen

👀

@nylen
Copy link
Member

nylen commented May 30, 2017

I see it :|

Probably caused by #929 somehow.

What error are you getting here?

@BE-Webdesign
Copy link
Contributor Author

BE-Webdesign commented May 30, 2017

Yeah it is caused by #929, but not to worry I think it can be resolved fairly easily.

Here is the warning message.

Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a 
class/function (for composite components) but got: undefined. You likely forgot to export your component 
from the file it's defined in.

Dashicon extends wp.element

We need to add the externals into the test environment, the only hangup I have is figuring out how to use node externals and another library in the same configuration. Was curious if you know how to do that.

@nylen
Copy link
Member

nylen commented May 31, 2017

Noting that this will be fixed by the current state of #935 (https://github.com/WordPress/gutenberg/pull/935/files#diff-512a8a050d031aaf7a1c47fb4f2a9656R10).

@youknowriad
Copy link
Contributor

closing as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants