Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form-token-field generated from a custom taxonomy doesn't display proper labels #9420

Closed
stockhuman opened this issue Aug 29, 2018 · 2 comments
Labels
Needs Technical Feedback Needs testing from a developer perspective. Needs Testing Needs further testing to be confirmed.

Comments

@stockhuman
Copy link

Describe the bug
Form inputs generated by custom taxonomies don't reflect the labels set in register_taxonomy(), instead defaulting to 'Add new Term" in the placeholder. Additionally, the hover pop-up when one goes to remove a term only describes it as a "Term" (ie: "Remove Term" instead of what's defined in the labels array).

To Reproduce
Steps to reproduce the behavior:

  1. Register a REST-queryable taxonomy with custom labels
  2. view the page/post/CPT that taxonomy is enabled for and go add a new term
  3. See the placeholder text does not reflect the labels set in the taxonomy
  4. See error

Expected behavior
One would expect to see the placeholder prop passed to the form so that "Add new Term" becomes, say, "Add a Byline".
screenshot

Env:

  • OS: Windows 10
  • Browser: Firefox (and others?)
  • Version: 61.0.2
  • Gutenberg: 3.6.2
@designsimply designsimply added the Needs Technical Feedback Needs testing from a developer perspective. label Aug 29, 2018
@youknowriad
Copy link
Contributor

Related #8448

@youknowriad youknowriad added the Needs Testing Needs further testing to be confirmed. label Aug 29, 2018
@youknowriad
Copy link
Contributor

I think this is fixed by #10962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Technical Feedback Needs testing from a developer perspective. Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

3 participants