Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor package: deprecated lifecycle method warning in TinyMCE #9037

Closed
vindl opened this issue Aug 15, 2018 · 1 comment
Closed

Editor package: deprecated lifecycle method warning in TinyMCE #9037

vindl opened this issue Aug 15, 2018 · 1 comment
Labels
[Package] Editor /packages/editor

Comments

@vindl
Copy link
Member

vindl commented Aug 15, 2018

The editor package is using the deprecated componentWillReceiveProps lifecycle method which produces console warnings when executed in React strict mode.

gutenberg/packages/editor/src/components/rich-text/tinymce.js

Line 117 in 4c28bd0

componentWillReceiveProps( nextProps ) { 

Warning: Unsafe lifecycle methods were found within a strict-mode tree:
...
componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: TinyMCE
@vindl vindl added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Aug 15, 2018
@vindl vindl mentioned this issue Aug 15, 2018
Closed
5 tasks
@ellatrix ellatrix removed the [Type] Bug An existing feature does not function as intended label Nov 21, 2018
@ellatrix
Copy link
Member

Was fixed in #11368.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Package] Editor /packages/editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vindl @ellatrix