Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce support for meta+Y shortcut #8921

Closed
fr-laurentn opened this issue Aug 13, 2018 · 8 comments · Fixed by #42627
Closed

Reintroduce support for meta+Y shortcut #8921

fr-laurentn opened this issue Aug 13, 2018 · 8 comments · Fixed by #42627
Assignees
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@fr-laurentn
Copy link

fr-laurentn commented Aug 13, 2018

Hello,

As discussed in #71, the support for meta+Y shortcut has been removed in

this.editor.shortcuts.remove( 'meta+y', '', 'Redo' );

The only way to redo an undone action for Windows users is to type CTRL+SHIFT+Z which is very uncommon (and not very user friendly).

CTRL+Y is a standard shortcut known by most of Windows users, unlike CTRL+SHIFT+Z.

Would it be possible to reintroduce the use of the meta+Y shortcut (or at least CTRL+Y)?

Thanks a lot,

EDIT: please note that I'm not asking to remove the CTRL+SHIFT+Z shortcut.

@chrisvanpatten chrisvanpatten added the [Type] Enhancement A suggestion for improvement. label Aug 13, 2018
@ellatrix ellatrix added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] History History, undo, redo, revisions, autosave. labels Feb 8, 2019
@ellatrix
Copy link
Member

ellatrix commented Feb 8, 2019

Yes, if it's the way for Windows, then we probably should. It's a bit annoying that there's no universal shortcut for it. On a May, cmd+Y is used in browsers to show all history, so we'd have to only add this shortcut for Windows, otherwise it clashes with a browser shortcut.

@afercia
Copy link
Contributor

afercia commented Sep 6, 2020

This was reported also on Trac, see https://core.trac.wordpress.org/ticket/49459, and that was one of the tickets the accessibility team milestoned for WordPress 5.5. The accessibility team would need some help (we did ask for help) to help this issue move on 🙂 Setting the milestone to WordPress 5.6. for visibility.

@afercia afercia added this to the WordPress 5.6 milestone Sep 6, 2020
@tellthemachines tellthemachines removed this from the WordPress 5.6 milestone Sep 16, 2020
@merapi
Copy link

merapi commented Oct 21, 2020

CMIIW: meta+y on Windows is win+y (does nothing, win = metaKey), on macOS, it's command+y (we don't want to hijack this [Show Full History], command = metaKey), can't we just use ["ctrl+z", "command+z"] for undo and ["ctrl+y", "command+shift+z"] for redo?

@Nantris
Copy link

Nantris commented Dec 15, 2020

@afercia can you elaborate on what help is needed? I'm having trouble accessing the Slack thread and this issue is sooooo aggravating. I love WordPress and I appreciate all the team does, but I really can't convey how much the lack of Windows redo hotkey support irks me. I really hope this will be prioritized, because the issue is nearly 30 months old now and I always pray it will be resolved the next time WordPress updates, but it never is.

It's especially bad for us since we have a global hotkey assigned to Ctrl+Shift+Z which means no redo unless we reassign that key any time we use WordPress. 99.9999% of the time not an issue on Windows because every other application supports Ctrl+Y.

@Nantris
Copy link

Nantris commented Jul 20, 2022

It's been almost 4 years since this was reported Can we please get this simple quality-of-life feature back?

Nobody uses Ctrl+Shift+Z for redo on Windows, and it conflicts with a global hotkey we use which makes the lack of the Ctrl+Y hotkey all the more annoying. That leaves us with only the option of using the mouse to redo, which is a horrible workflow.

I'm not sure who the relevant people would be to ping for this, so apologies for probably pinging the wrong people.

@afercia @adamziel @ntsekoura @ellatrix

@ellatrix
Copy link
Member

@slapbox I created #42627. Could you test?

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 22, 2022
@ellatrix
Copy link
Member

it conflicts with a global hotkey

What program is using that combination?

@Nantris
Copy link

Nantris commented Jul 22, 2022

@ellatrix thank you so much for your speedy response and PR to resolve this! I'm very appreciative for you taking a crack at this.

I'd be happy to test the changes, but I'm not sure how I can actually do that?

What program is using that combination?

The program using that hotkey globally is Recollectr. It's re-assignable, but it's a pain to re-assign it and revert it only when working in WordPress. Besides that, my brain is pretty much locked to Ctrl+Y for redo after decades of using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants