Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: consolidate + simplify size controls #8397

Closed
sarahmonster opened this issue Aug 2, 2018 · 5 comments
Closed

Image block: consolidate + simplify size controls #8397

sarahmonster opened this issue Aug 2, 2018 · 5 comments
Labels
[Block] Image Affects the Image Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@sarahmonster
Copy link
Member

If I want to change the size of an image, there are currently four different ways of accomplishing this:

  • the image size drop-down
  • editing the width and height values
  • selecting 25/50/75/100%
  • scaling using the blue dot handles.

This leads to a slightly cluttered-looking settings sidebar:

screenshot 2018-08-02 14 30 18

As a user, I don't immediately understand the difference between "Image size" and "Image dimensions", and it's not immediately clear (particularly in a default state) what the former refers to.

Some suggestions for improvement:

  • Since there's so much going on with the image size, I think it might be better if it were its own section/panel here, at the very least.
  • "Image size" should be renamed to something more descriptive—"predefined image size"? I'm not sure exactly what it should be called, but I'm sure there's a better way to communicate "size templates that your theme or plugins have provided."
  • I think the 25/50/75/100 would be a good candidate for removal here. My guess is that they exist here to allow proportional image resizing, but I think that could be better accomplished with a "lock proportions" button here, a la graphics programs:

screenshot 2018-08-02 17 11 12

screenshot 2018-08-02 17 12 09

@sarahmonster sarahmonster added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Aug 2, 2018
@sarahmonster sarahmonster mentioned this issue Aug 2, 2018
11 tasks
@ZebulanStanphill
Copy link
Member

I think Image Size could be renamed to Image Source Size. I would be in favor of removing the proportional size shortcuts in favor of the ability to lock the image dimensions together.

I made an issue about this: #7636. See also: #7638.

@xavivars
Copy link

xavivars commented Nov 20, 2018

IMHO, the blue dots are everything but intuitive, even more when the image has a white background. (see example)

image

It would be great if there was some kind of "dashed/dotted border highlighting", like in some image editors, that would make it easier to realize those are actual places to scale the image. Also, having a control in the bottom-right corner (to fix ratio) would be great.

@nabrown
Copy link

nabrown commented Jan 13, 2021

Are there any plans to implement the lock aspect ratio bit of this enhancement? I agree the % selectors should be removed. It's not even clear if it indicated a percent of the image's inherent dimensions or a percent of its container.

@mtias
Copy link
Member

mtias commented Feb 23, 2021

The biggest part of this work (consolidation) is going to happen through the "Dimensions" panel described in #27331

@mtias
Copy link
Member

mtias commented Jul 13, 2021

There's a lot of improvements in the width handling and more to come. Going to close this as it's not very actionable on its own.

@mtias mtias closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants