Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic Block: Read More tag is missing "More" text label. #8372

Closed
kjellr opened this issue Aug 1, 2018 · 1 comment
Closed

Classic Block: Read More tag is missing "More" text label. #8372

kjellr opened this issue Aug 1, 2018 · 1 comment
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Milestone

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 1, 2018

Describe the bug

In the current classic editor, the "More" divider has a text label inside of it, to more clearly convey what the dotted line means:

screen shot 2018-08-01 at 1 56 34 pm

The classic block removes that label:

screen shot 2018-08-01 at 1 56 39 pm

I'm unsure if that was intentional or not, but I think including the label would be more clear — the dotted line on its own is confusing.

To Reproduce

  1. Add a Classic block
  2. Insert a "Read More" tag from the Classic bar's toolbar.
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Aug 1, 2018
@kjellr kjellr mentioned this issue Aug 1, 2018
6 tasks
@ellatrix ellatrix added the [Block] Classic Affects the Classic Editor Block label Oct 31, 2018
@mtias mtias added this to the WordPress 5.0.x Follow Ups milestone Nov 12, 2018
@draganescu draganescu self-assigned this Feb 25, 2019
@draganescu
Copy link
Contributor

draganescu commented Feb 27, 2019

@kjellr It appears to have been an optimisation of some sort, b/c in the classic editor the more tag used a large image to set that more text on a dashed line while the classic block uses a dashed border. I am looking into using some pseudo element and a wrapper to the image in the classic block to achieve the same effect, or maybe just revert to the old image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants