Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+A unexpected behaviour #8269

Closed
LZL0 opened this issue Jul 28, 2018 · 4 comments
Closed

Ctrl+A unexpected behaviour #8269

LZL0 opened this issue Jul 28, 2018 · 4 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended

Comments

@LZL0
Copy link

LZL0 commented Jul 28, 2018

Describe the bug
Ctrl+A unexpected behaviour
I believe this behaviour to be unexpected, please correct me if I am wrong.

https://www.youtube.com/watch?v=-jXVM5zH8Qg

Disclaimer: The first time it works, but after that it starts to act this way.

Steps to reproduce the behavior:

  1. Click into a block.
  2. Press Ctrl + A.
  3. Gutenberg acts as expected, only the current paragraph is being selected.
  4. Click into another block or exit the current one and click into it.
  5. Press Ctrl + A again.
  6. All the blocks are selected.
    If you reload the page on the first Ctrl+A command it would function as expected.

Gutenberg version 3.3
WordPress version 4.9.7

@LZL0
Copy link
Author

LZL0 commented Jul 29, 2018

Must be connected with Issue #8268

@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Decision Needs a decision to be actionable or relevant labels Jul 30, 2018
@designsimply
Copy link
Member

designsimply commented Jul 30, 2018

I found a description of the expected behavior in #4600:

Focus an Editable. meta+a should select all contents. Press meta+a once more to select all blocks.

@iseulde or @jasmussen what is the expected behavior if you press meta+a then click on a different block and press meta+a again?

@jasmussen
Copy link
Contributor

what is the expected behavior if you press meta+a then click on a different block and press meta+a again?

The expected behavior is this:

  • Set focus in a paragraph, press meta+a to select all contents in that paragraph
  • Only when all the text of that paragraph is selected, should a subsequent meta+a expand the selection to all blocks.

This also means that if you select all text in one paragraph, select a different paragraph, you've effectively "unset" the selection for the previous block, and meta+a should select all the text in the new block before expanding.

Noting that if you deselect all blocks and press meta+a, all blocks should be selected.

Noting that this works as expected for me in the current release version of the plugin in Chrome, so this could be a browser or operating system specific bug. See also #7678 and discussion here #4369 (comment)

@designsimply designsimply removed the Needs Decision Needs a decision to be actionable or relevant label Jul 31, 2018
@mtias
Copy link
Member

mtias commented Oct 27, 2018

Closing as works as expected. There are some incosistencies in browsers that are still being worked on.

@mtias mtias closed this as completed Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants