-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subhead should support multiple use #8140
Comments
This has a PR now, #8143, for those with labeling powers :) |
No it was added as a single use block under the title #2091 Do we really need this Block? It is a paragraph with a class. I don't think many people, including me, really understand when to use this block. |
@Soean I know it was made single use when it was originally added, I'm just saying maybe it should be multi-use so it can be used in content with multiple sections. But in that case I also think removing it and make it a block style on the paragraph block would be fine. Is that a (Also fwiw I think the idea of the subhead is much more common/understood by folks in journalism/newsrooms.) |
Added the |
Whether it should be an h-tag or a paragraph is up to interpretation, although I'm of the opinion that a Another way to think about it: if you were generating a table of contents from H-tags (as we do in the Document Outline popover), you wouldn't want the subheads in there, therefore they are more appropriate as |
Just for the sake of clarity, here are our options (I think):
|
Let's keep it for now as a single use. I have seen it used by people so for now keeping it makes sense. We can always revisit this decision. |
It seems really confusing to explain to most users what the display/SEO ramifications are of using a Subheading, it's also very hard to see in the UI that it's only available once (and the plugin above presents a concern). I like @chrisvanpatten's idea of adding it as a block style, I'd also add two other ideas:
|
I have to say this block doesn't make a lot of sense to me in its current implementation. If it's mean to be a subtitle it should probably also enforce position — first block of the post. If it's more of a general purpose block, marking it as "use once" seems a bit arbitrary. It seems like a valuable addition if / when the title can be a full block as well, and you use it in conjunction with a featured image block, an excerpt block, etc. If that is the case, we might be ok just hiding it for now (not removing it, so it doesn't affect those that are already using it). |
I'll reiterate I love the idea of this block and appreciate how it can be used (and now the nuance between this and a small Heading)... but with the limitations of the current name and single-use flag I think add much more confusion than value to most users. |
Looping back to this as we are considering removing it in #9308. Thanks everyone for working through this and highlighting the confusion. |
Subheads currently have
supports.multiple = false
but I believe this should betrue
.The main use-case would be an article or page with multiple sections, which need a subhead for each section of content.
The text was updated successfully, but these errors were encountered: