Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag autocompleter inconsistent interaction #8028

Closed
afercia opened this issue Jul 18, 2018 · 0 comments · Fixed by #8031
Closed

Tag autocompleter inconsistent interaction #8028

afercia opened this issue Jul 18, 2018 · 0 comments · Fixed by #8031
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 18, 2018

Consistent and predictable interaction with UI is key for a good user experience. Tools that behave in a similar way should have a similar interaction.

The "tags autocompleter" in Gutenberg misses a couple features used by similar tools in Gutenberg itself and in the Classic Editor:

screen shot 2018-07-18 at 17 21 56

  • it should close when pressing Escape
  • it should cycle through the suggestions when using arrows navigation

Worth noting:

  • the tags autocompleter in the Classic Editor closes on Escape and cycles
  • all the autocompleters in Gutenberg do the same, e.g.: mentions, slash inserter
  • not to mention cycling through options is pretty standard in Gutenberg, see all the various menus
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Jul 18, 2018
@afercia afercia mentioned this issue Jul 18, 2018
Merged
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tags autocompleter keyboard interaction improvements. WordPress/gutenberg
2 participants
@designsimply @afercia