Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting from an audio block with a formatted caption to a file block results in an incorrect file link #7626

Closed
talldan opened this issue Jun 29, 2018 · 2 comments
Assignees
Labels
[Feature] Block Transforms Block transforms from one block to another [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Jun 29, 2018

Describe the bug
When converting from an audio block that has a formatted caption (bold/underlined/strikethrough formating applied) to a file block, the caption is expected to be displayed as the link to the file. However, the conversion process is not correctly removing the applied formatting, causing [object Object] to be displayed.

File block is a new block being introduced in #7622

To Reproduce
Steps to reproduce the behavior:

  1. Create an audio block
  2. Add a caption to the audio block with formatted text (e.g. bold, underline, strikethrough, italic)
  3. Convert the audio block to a file block
  4. Note that the file link contains [object Object] where formatting was applied

Expected behavior
Any formatting should be removed and purely the text of the caption should be shown as the file link

Screenshots
formatting-bug

@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Jun 29, 2018
@jorgefilipecosta jorgefilipecosta self-assigned this Jul 9, 2018
@mtias mtias added the [Feature] Block Transforms Block transforms from one block to another label Jul 19, 2018
@sarahmonster
Copy link
Member

This issue also exists when converting an image to a file:

2018-07-30 14 14 13

This was referenced Jul 30, 2018
@jorgefilipecosta
Copy link
Member

This bug was solved during the changes to the formatting API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Transforms Block transforms from one block to another [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants