Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes keyboard navigation and manipulation is confusing #7412

Closed
koke opened this issue Jun 20, 2018 · 2 comments
Closed

Quotes keyboard navigation and manipulation is confusing #7412

koke opened this issue Jun 20, 2018 · 2 comments
Labels
[Block] Quote Affects the Quote Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...

Comments

@koke
Copy link
Contributor

koke commented Jun 20, 2018

There are a number of issues when you try to edit quotes with the keyboard.

As in the case of paragraphs, I would expect a double enter to trigger a new block (quote or now).

quotes-1

This doesn't work either when trying to split a quote in two

quotes-2

Trying to merge quotes doesn't work either, as pressing backspace at the beginning of the second quote just move the cursor (inexplicably) to the beginning of the previous quote, instead of combining the two quotes.

quotes-3

When you try to select, you can do it one character at a time, but if you press shift-down to try to select the whole quote, it will just move the cursor.

quotes-4

Desktop (please complete the following information):

  • OS: macOS
  • Browser Safari
  • Version 11

Additional context

  • Tested with Gutenberg 3.0.1
@mtias mtias added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Jul 19, 2018
@youknowriad youknowriad added the [Block] Quote Affects the Quote Block label Feb 8, 2019
@draganescu
Copy link
Contributor

As of Gutenberg 7.9.1 part of the things described here are partially solved:

  1. Pressing Enter twice in a quote takes the cursor out of the quote
  2. Pressing backspace from a quote following another quote will merge the two and keep the cite of the lowest one
  3. Selecting with keyboard has been improved and pressing arrow down while selecting does not move the cursor to the cite anymore, but selects the whole quote instead.

@koke could you re-test and update the issue accordingly or close it if the new behavior is good enough?

@koke
Copy link
Contributor Author

koke commented Apr 24, 2020

Yes, everything reported seems to work nicely in 7.9.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Projects
None yet
Development

No branches or pull requests

4 participants