Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move positioning of page update success message #7276

Closed
pojke opened this issue Jun 12, 2018 · 10 comments
Closed

Move positioning of page update success message #7276

pojke opened this issue Jun 12, 2018 · 10 comments
Assignees
Labels
[Feature] Permalink The permalink of a post or page and the experience of setting or editing it Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@pojke
Copy link

pojke commented Jun 12, 2018

When updating a permalink in Gutenberg and publishing the page, we're losing an access to the permalink. It's a bad UX as a user wants to confirm that the permalink is changed

image

Ideally the success message would be above the editor so there's no way it hovers over any element.

@maddisondesigns
Copy link

This is another good reason for making that Post updated message auto-close, as it hides content - #4495

@mtias mtias added the Needs Design Feedback Needs general design feedback. label Jul 19, 2018
@karmatosed
Copy link
Member

I would like us to consider not having this message at all. Could we update enough information in the 'saved' indicator without this?

@pojke
Copy link
Author

pojke commented Jul 29, 2018

@karmatosed I'd say it's an option, however, there's a couple important considerations:

  1. The failed message is in the same place, I think it's much more important than "saved" to be quite visible and distinct
  2. Mobile version and the amount of text you can fit on mobile (currently has only an icon afaik)

@karmatosed
Copy link
Member

@pojke good points, I do think it's worth exploring though how this could look. Is it in the right place? Is it the right styling?

@jasmussen
Copy link
Contributor

It seems like this issue can be improved in two ways:

  1. Adjust the permalink interface so it isn't covered by the notice. I believe there's a separate ticket both for redesigning that interface, but we can also make the notice slightly smaller in height and go a long way.
  2. Add a feature to the notice component that allows it to fade out.

2 is somewhat bigger, but is probably the best long term fix for this. Things like "Post updated" and "Post published" are probably fine to fade out after a short delay, whereas things like "Post failed saving, connection issues" should not fade out.

So let's keep this issue in the pool and hope that pull requests trickle in here!

@jasmussen jasmussen removed the Needs Design Feedback Needs general design feedback. label Oct 11, 2018
@designsimply designsimply added [Feature] Permalink The permalink of a post or page and the experience of setting or editing it Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement. labels Nov 8, 2018
@designsimply
Copy link
Member

designsimply commented Nov 8, 2018

I added the Good First Issue label for the following two action items noted above:

  1. Make notices smaller in height.
  2. Make non-critical notices fade out.

Regarding redesigning the UI for permalinks, I couldn't find an open issue for that. I organized open issues in to a label: https://github.com/WordPress/gutenberg/labels/Permalinks

@greatislander
Copy link
Contributor

greatislander commented Dec 6, 2018

In WordPress 5.0 this behaviour is still there, with the updated notice blocking the permalink above the post/page title:

Screenshot of Page Updated notice blocking permalink editor

Since WordPress < 5.0 supports notices with a fade class which fades them out, I think @jasmussen / @designsimply's second points above would be a good place to start? If so I would be interested in starting to work on a PR for this…

@mapk
Copy link
Contributor

mapk commented Jan 23, 2019

I see a couple options here:

1. Title block becomes its own block.
Phase 2 plans to break out the Title Block to be its own block [#11553]. There's discussion about what to do with the URL field on that issue. This will likely solve this issue of having the URL hid under the messaging.

2. Take advantage of the disabled "Publish" button.
Swap the disabled "Publish" button with a "View Post" btn instead. Just throwing this out there b/c I'm not sure its been explored yet.

Current view:

current-disabled-btn

Possible iteration:

view-post-btn

I do believe the latter option fails in a couple ways:

  1. The button still being blue really isn't enough visual feedback to indicate a successful publish.
  2. There's just no emotional "Yeah, I did it!" feeling there.

@mapk
Copy link
Contributor

mapk commented Jan 23, 2019

Ultimately, if we think the Title Block issue will resolve this, we might be able to close this issue. Any thoughts?

@jasmussen
Copy link
Contributor

Glad to find this ticket again! It is a perfect ticket to keep open and resolve by porting the improvements that were made in #12301 (comment).

I think I'll try and assign myself on this one and make that happen.

To clarify — the improvements made in the PR linked above push down the editing canvas when notices appear. This solves the problem entirely, in a great way.

Title block discussions are good to have, but IMO irrelevant to this ticket.

@jasmussen jasmussen self-assigned this Jan 24, 2019
@noisysocks noisysocks added the [Status] In Progress Tracking issues with work in progress label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Permalink The permalink of a post or page and the experience of setting or editing it Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

9 participants