Consider removing either the JS maxWidth or the ability to set max-width from CSS

[azaozz]

The editor width can be set by themes and plugins from CSS. At the same time there is a https://github.com/WordPress/gutenberg/blob/master/editor/store/defaults.js#L62 maxWidth JS setting. Thinking there should be either one or the other, but not both.

If we are keeping the CSS max-width, it would be great to have a property (maxWidth, editorWidth...) set in JS, but it will have to be set after the editor loads. Alternatively can disallow (always override) the CSS max-width in favor of the JS maxWidth. Plugins and themes can use that instead when they want to change it.

[azaozz]

Thinking a bit more about this, we should probably drop the JS var and replace it with a small utility function returning the current editor width (that would run on render) and be globally accessible. Having a hard-coded width would fail on small screen devices when the responsive styling kicks in.

[lzs]

I wonder if this is still being worked on? I see some elements (such as a DIV around a IMG within a wp-block-image) that is styled directly with "max-width: 580px", presumably from $maxWidth.

[gziolo]

@jasmussen - is it something we still need?

[jasmussen]

I'm unsure. Maybe Andrew is best to respond?

[azaozz]

The maxWidth "constant" is still there https://github.com/WordPress/gutenberg/blob/master/packages/block-editor/src/store/defaults.js#L124, and is sometimes "incorrect" :) (actual width is changed by theme/plugin CSS). Not sure why it exists.

If it is to be used for images, it needs to be correct, or it just messes things up. Perhaps a global utility function to get that from the current dom (i.e. what the user sees at the moment) would be better.

On the other hand, fixing this would be best done when we know how themes are going to use context for images on the front-end, or if they will need something like that at all. (Ideally on the front-end all images will always have width and height attributes or we end up with jumping pages..).

[kadamwhite]

Cross-referencing to #6652 based on @azaozz' latest comment, above.

maxWidth also appears to be part of the issue behind #17795