Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Inserter accessibility implementation #7052

Closed
afercia opened this issue May 31, 2018 · 1 comment
Closed

Simplify the Inserter accessibility implementation #7052

afercia opened this issue May 31, 2018 · 1 comment
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented May 31, 2018

After #6636 the Inserter is now using collapsible panels (accordions). As mentioned in #6168 (comment) this allows also to re-think and simplify the accessibility part.

Previously, each category group in the inserter had the semantic of an ARIA menu with menuitems. Also, navigation with arrow keys was implemented, as that's typical for ARIA menus. In fact, in its initial versions, the Inserter design and interaction were closer to the one of a menu. For some history, see below the Inserter in Gutenberg 1.1.0, 1.4.0, and 1.7.0.

screen shot 2018-05-31 at 14 02 09

The Inserter has now a completely different interaction model. I'd say menu and menuitems don't make much sense any longer. I'd also consider to remove arrows navigation and greatly simplify the interaction and code. Let's just let users Tab through the available blocks in the accordions. I'd also propose to remove the active item tracking, as that made sense to allow quick Tab navigation through the categories. Now that accordions can be collapsed or expanded by users, that appears to be a bit overkill.

The current accordions work pretty well, they're simple to use and understand also when using assistive technologies. Seems to me there's really no need to overcomplicate.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 31, 2018
@afercia afercia self-assigned this May 31, 2018
@anevins12
Copy link
Contributor

anevins12 commented May 31, 2018

Now that accordions can be collapsed or expanded by users, that appears to be a bit overkill.

Yes and may cause errors because the keyboard shortcuts are not predictable for the model being used - conveyed via the Role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants