Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wp.blocks.createBlock in transforms handlers #688

Closed
aduth opened this issue May 5, 2017 · 0 comments · Fixed by #690
Closed

Use wp.blocks.createBlock in transforms handlers #688

aduth opened this issue May 5, 2017 · 0 comments · Fixed by #690
Assignees
@aduth
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented May 5, 2017

wp.blocks.createBlock was introduced in #407 as a helper to avoid needing to manually create block instances. We should use this consistently; notably, we're manually creating block objects in transforms.

Example: https://github.com/WordPress/gutenberg/blob/af4a499/blocks/library/quote/index.js#L36-L41
@aduth aduth added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take labels May 5, 2017
This was referenced May 5, 2017
Closed
Merged
@aduth aduth self-assigned this May 5, 2017
@aduth aduth added the [Status] In Progress Tracking issues with work in progress label May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aduth aduth

Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use createBlock helper in place of manual block creation WordPress/gutenberg
1 participant
@aduth