Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parent block selector while in Write mode #66684

Closed
Tracked by #60021
richtabor opened this issue Nov 1, 2024 · 0 comments · Fixed by #67395
Closed
Tracked by #60021

Remove parent block selector while in Write mode #66684

richtabor opened this issue Nov 1, 2024 · 0 comments · Fixed by #67395
Assignees
Labels
[Feature] Write mode [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Nov 1, 2024

Brief

The current implementation of the parent block selector in Write mode disrupts the editing paradigm, as selecting the parent block leads to editing design-level (the parent <main> group block in a template or the post/content block otherwise.

Write mode is designed to simplify content input and prioritize content-focused interactions, but editing the top-most parent block while in this mode breaks this intended separation between writing and design.

Additionally, the parent block selector becomes less useful in Write mode for patterns. Write mode already flattens patterns, allowing easier selection and interaction, making the parent block selector nearly redundant in this context.

Steps to Reproduce

  1. Enter Write mode.
  2. Select text in a pattern.
  3. Select the parent block selector to select the current pattern.
  4. Select the parent block selector again to select the block surrounding all patterns.
  5. Now you're at the top-level container group, or the post/content block—no longer editing content.

Expected Behavior

In Write mode, the focus remains on writing and direct interaction with patterns and their content blocks only.

Actual Behavior

Selecting a top-most parent block shifts the interaction toward design-oriented edits, misaligning with the Write mode’s purpose.

Visual

Note how using the parent block selector gets you to the Post Content block, which is not within the Write mode conditions, allowing design tooling while in Write mode. Also note how selecting the pattern in Write mode is as effective—if not more—than using the parent block selector.

CleanShot.2024-11-01.at.13.24.35.mp4
@richtabor richtabor changed the title Consider removing parent selector in Write mode. Remove parent block selector while in Write mode Nov 1, 2024
@richtabor richtabor added the [Type] Enhancement A suggestion for improvement. label Nov 1, 2024
@jorgefilipecosta jorgefilipecosta self-assigned this Nov 26, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Write mode [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants