Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block setup states: Include both inspector and toolbar options for setting and resetting #66563

Open
jasmussen opened this issue Oct 29, 2024 · 2 comments
Labels
Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

Consider the Site Logo block in its setup state:

Image

This selected Site Logo block shows:

  • "Choose logo" in the block toolbar
  • "Choose logo" as a matching button in the inspector

When a media file is added, both of those are updated:

Image

In this case, the selected Site Logo block shows:

  • "Replace" in the block toolbar
  • The filename of the image, plus a thumbnail, in the media button in the inspector.

Beyond the basic usability, this also has benefits as far as scaling down to tiny sizes in complex patterns. See #64288.

The pattern from Site Logo would be good to make consistent across all similar blocks. In most cases, this would mean adding a panel to the inspector, "Media".

Image

Image

Missing "Media" section.

Media & Text

Image

Missing "Media" section, and block toolbar option.

Cover

Image

Missing "Media" section initially, it's there when an image has already been set. Also, it should be "Add media", not "Add Media".

Query Loop

Image

Directly related to enhancements outlined in #64288, it's missing the toolbar option, as well as a section in the inspector. Since this is about swapping out patterns, rather than adding media, the pattern could potentially be the collapsed "Design" section, that's similar for when you choose page-level patterns in the document status inspector.

@jasmussen
Copy link
Contributor Author

Curious your thoughts, @annezazu!

@annezazu
Copy link
Contributor

annezazu commented Nov 1, 2024

Absolutely love this and think this would help immensely for consistency, especially when we think about "write" mode. For example, I think having a 'design' section for the query loop would be a great thing to display in a contentOnly representation #66614.

@jasmussen jasmussen added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Nov 13, 2024
@jasmussen jasmussen moved this from Now to Needs Dev in Design priorities Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
Status: Needs Dev
Development

No branches or pull requests

2 participants