-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template part selecting and editing unavailable in “Write” mode #66463
Comments
Noting that this includes if you switch between Write and Design modes. If you enter Write mode, it completely removes the ability to select template parts in list View even after switching to Design mode, even though you can select them. This is a demo with GB 19.6: list.view.write.mode.mov |
Hm.. I can't reproduce on trunk. @annezazu can you test in trunk too? I'll keep digging a bit more though to see if there was a PR that fixed that.. |
I've been able to replicate what @annezazu describes on a simple edge site using v19.6.0:
Screencast.from.07-11-24.10.46.06.webm |
Replicated as well on a simple site running v19.5.1: Screencast.from.07-11-24.10.58.29.webm |
I've downgraded my simple edge site to v19.4.0 and there I can see that the content of the list view changes when switching between write/design modes: Screencast.from.07-11-24.11.05.45.webm |
I tried this in .com and actually reproduced. Could it be happening only there? |
This bug was introduced to dotcom with this PR: #65945 |
Thank you all for diving in! I see a PR is underway to address this. |
I'm going to reopen this since the original problem remains in this issue. Namely that you cannot view or edit template parts when Write mode is enabled: no.ability.to.edit.template.parts.movTo be clear, I'd expect to be able to both see the template parts in List View and then be able to edit the content of individual blocks. Part of the issue is that we need to ensure blocks like Site Title are compatible with contentOnly and that we have a way to edit/manage a menu with contentOnly. With that said though, for now, we should be able to see the template parts in List View and have a contentOnly experience, even if there is a lock icon and you cannot select anything. |
Na, occurs universally. |
I've traced the origin of this behavior back to #65204. On the previous commit (PR #65373) it's possible to view and edit template parts, even though at that point the |
That's the PR that originally introduced Write Mode, so there's no regression of behavior. It's something that was never implemented. |
When the editor is set to “Design” mode, users can select template parts, which renders an “Edit” button allowing isolated editing of the template part. However, this functionality is unavailable in “Write” mode.
But if you enter the editor, turn on write mode, and open list view, template parts aren't visible in the list view nor can you edit them. I can replicate this with Twenty Twenty-Five, as well as other block themes with both 6.7 trunk & Gutenberg trunk on:
open.mode.early.then.list.view.mov
The text was updated successfully, but these errors were encountered: