-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: add sortable, multi-selectable list #66413
Comments
Could this be a use case for Here's a rough mockup based on the designs in #64445: |
@swissspidy what do you think? I will note that, in any case, this would be:
For the combobox part, we'd need to establish if the current |
Interesting, thanks for sharing! It's quite the deviation from the current battle-tested solution, which is based on the listbox pattern. At first glance it seems to cover the functionality for mouse users, but it misses things like a visual indication of the currently selected element, so that you can easily move and remove items using keyboard shortcuts. But I'll have to defer a detailed analysis to the accessibility team :) Design-wise we'd have to see how well it could be integrated into the |
In terms of keyboard navigation I would expect something similar to the List layout in Data Views: list.mp4I suggest this design mainly because compared to the version in wp-admin it has a lot of potential for reuse, particularly in the editor where similar ad hoc creations exist already (see custom shadow style creation). |
I like the idea of itemgroup being a good candidate for systematizing these views. I believe I saw a few similar cases on Woo and other plugin options where a short list of items with built in drag and drop / reorder would be a solid addition. Folks were lookign at data views for it, but that seems way overboard for these simpler use cases that don't need flexible columns, data type, and various sorting options. |
Related to the ItemGroup, there are some mockups later in the thread based on this exact conversation. |
As discussed in #64686 (review), we'd like to add a new component to the
@wordpress/components
package to render a "sortable, multi-selectable list".So far
#64686 showcases the first need for such a component, although we should consider visual and API design first before getting to build it.
In terms of visual design, this is what exists in #64686 👍
And in technical terms we'd likely want to
This may be a chance to consider abstracting some of the listbox work into its own separate component (see #65801).
Next steps
At a very high level
cc @swissspidy
The text was updated successfully, but these errors were encountered: