Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Deprecate 36px default size #65751

Open
2 of 18 tasks
mirka opened this issue Sep 30, 2024 · 2 comments
Open
2 of 18 tasks

Components: Deprecate 36px default size #65751

mirka opened this issue Sep 30, 2024 · 2 comments
Assignees
Labels
[Package] Components /packages/components [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@mirka
Copy link
Member

mirka commented Sep 30, 2024

Part of #46741

In our transition process to the new 40px default sizes, we are now ready to officially start the deprecation period by logging console warnings.

List of components

Procedure

- [ ] Log deprecation warning
- [ ] Update unit tests
- [ ] Update Storybook
- [ ] Update code snippets (Storybook, JSDoc, README)
- [ ] Changelog
- [ ] Add Dev Note tag
@mirka mirka added [Package] Components /packages/components [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Sep 30, 2024
@mirka mirka self-assigned this Sep 30, 2024
@hbhalodia
Copy link
Contributor

Hi @mirka, I would like to pick some of the controls to add the deprecations. Should I wait until any of the PR get's merged to use the maybeWarnDeprecated36pxSize utility function?

Thank You,

@mirka
Copy link
Member Author

mirka commented Oct 9, 2024

@hbhalodia Awesome! Yes, I'll need to merge those first. I'll ping you when this is ready for contributors 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

2 participants