Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom out may break out of canvas in Twenty Twenty Five theme #65673

Closed
getdave opened this issue Sep 26, 2024 · 15 comments
Closed

Zoom out may break out of canvas in Twenty Twenty Five theme #65673

getdave opened this issue Sep 26, 2024 · 15 comments
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Zoom Out [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Sep 26, 2024

In the report below it appears that TT5 may break Zoom Out (or Zoom Out doesn't cater for something special TT5 is doing).

Pinging @sarahmonster @MaggieCabrera for expertise.

Needs triage.


testing

There's a curious width issue, not sure if it's related to this branch or not:

widthissue

Originally posted by @jasmussen in #65392 (comment)

@getdave getdave added [Type] Bug An existing feature does not function as intended [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Zoom Out labels Sep 26, 2024
@MaggieCabrera
Copy link
Contributor

I could not reproduce this by inserting these patterns in a page. I did find that the full page patterns in TT5 are wrapped in a group, which invalidates zoom out and maybe that should be patched within the theme

@MaggieCabrera
Copy link
Contributor

The problem is the yellow pattern, the text is too big and it causes overflow on zoom out. I am not sure if the problem should be fixed on TT5 or if anything else should be done in zoom out too.

Editor Frontend
Screenshot 2024-10-03 at 18 39 17 Screenshot 2024-10-03 at 18 40 05

@jasmussen
Copy link
Contributor

We probably want to improve it in TT5, however it seems like something we might want zooming to handle as well. Can you try just a really long paragraph, see how that fares?

ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff

@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Oct 4, 2024

There seems to be something weird going on. Without zoom out mode at all, this is the editor vs the frontend:

Editor:
Image

Frontend (a horizontal scrollbar appears):
Image

@jasmussen
Copy link
Contributor

Hrm. We might need a word-break rule somewhere. I guess this is a theme thing?

@MaggieCabrera
Copy link
Contributor

Hrm. We might need a word-break rule somewhere. I guess this is a theme thing?

No, I saved a post with this template pasted and moved to emptytheme and the inconsistency persists

@getdave
Copy link
Contributor Author

getdave commented Oct 4, 2024

This isn't a Zoom Out specific thing then right?

@MaggieCabrera
Copy link
Contributor

This isn't a Zoom Out specific thing then right?

I see two different things here:

  • The difference between editor and frontend. That seems like an editor issue
  • The zoom out problem, that looks like a zoom out scaling issue, since it should work like the editor and overflow the wording. I think this is covered by Scaling not one to one when zooming out #65757

In any case, TT5 is not at fault beyond just having big text that highlights this issue. I checked the theme and it has very little CSS, so this kind of issue could affect any other theme.

@richtabor
Copy link
Member

Is it just the big text that is causing the zoom out distortion? We can make it smaller to mask the issue while #65757 is being explored.

@MaggieCabrera
Copy link
Contributor

Is it just the big text that is causing the zoom out distortion? We can make it smaller to mask the issue while #65757 is being explored.

yes, if you remove the Stories pattern it goes away

@richtabor
Copy link
Member

Related #65974

@colorful-tones
Copy link
Member

I'm not sure how/why this was not on the WP 6.7 board, but I'm adding it now.

@colorful-tones colorful-tones moved this to 🗣️ In Discussion / Needs Decision in WordPress 6.7 Editor Tasks Oct 14, 2024
@colorful-tones
Copy link
Member

I just tested this in WP 6.7 beta 2 with Twenty Twenty-Five and I am not able to recreate the original issue reported:

In the report below it appears that TT5 may break Zoom Out (or Zoom Out doesn't cater for something special TT5 is doing).

and

There's a curious width issue, not sure if it's related to this branch or not:

I'm not sure what branch @getdave was referring to?

However, there is a separate issue later referred to and likely worthy of opening a separate issue for:

The difference between editor and frontend. That seems like an editor issue

The issue persists, and it seems to be related possibly to browser styling. In Chrome 129 there are some additional styles that are output in the editor only:

p[Attributes Style] {
    -webkit-user-modify: read-write;
    overflow-wrap: break-word;
    -webkit-line-break: after-white-space;
}

This seems odd to me that they're only output by the browser and only in the editor? 😕

Image

@MaggieCabrera
Copy link
Contributor

I think we can close this one as fixed via #65757 and let's open a new one regarding the frontend/site editor disparity, which is unrelated to zoom out or TT5

@getdave
Copy link
Contributor Author

getdave commented Oct 16, 2024

Ok let's close out 👍

@getdave getdave closed this as completed Oct 16, 2024
@github-project-automation github-project-automation bot moved this from 🗣️ In Discussion / Needs Decision to ✅ Done in WordPress 6.7 Editor Tasks Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

No branches or pull requests

5 participants