Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: select tab id and visual highlight are out of sync when removing tab #65576

Closed
ciampo opened this issue Sep 23, 2024 · 4 comments · Fixed by #66207
Closed

Tabs: select tab id and visual highlight are out of sync when removing tab #65576

ciampo opened this issue Sep 23, 2024 · 4 comments · Fixed by #66207
Assignees
@ciampo
Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@ciampo
Copy link
Contributor

ciampo commented Sep 23, 2024

This can be currently reproduced in Storybook:

Kapture.2024-09-23.at.17.19.53.mp4
@ciampo
Copy link
Contributor Author

ciampo commented Sep 23, 2024

cc @DaniGuardiola

@ciampo ciampo added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Sep 23, 2024
@ciampo ciampo mentioned this issue Sep 23, 2024
Merged
@DaniGuardiola
Copy link
Contributor

Yep, I'm aware of this one and have a simple solution already on my mind, just need to get through the in-progress stuff and then I'll handle this. Thanks for reporting.

@ciampo
Copy link
Contributor Author

ciampo commented Oct 1, 2024

Just flagging that this bug "evolved" after the latest work on Tabs, and now manifests differently (and arguably providing a worse UX):

Kapture.2024-10-01.at.11.08.34.mp4

@DaniGuardiola
Copy link
Contributor

Thanks, yeah makes sense that the bug evolved like this, I'm gonna fix this as my next priority as I follow up on the Tabs and ToggleGroupControl work by cleaning things up and sharing a bit more code.

@ciampo ciampo mentioned this issue Oct 2, 2024
Open
@ciampo ciampo mentioned this issue Oct 17, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciampo ciampo

Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tabs: update indicator more reactively WordPress/gutenberg
2 participants
@ciampo @DaniGuardiola