Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Expand ProgressBar functionality and visual customization #65528

Open
keoshi opened this issue Sep 20, 2024 · 2 comments
Open

Components: Expand ProgressBar functionality and visual customization #65528

keoshi opened this issue Sep 20, 2024 · 2 comments
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Type] Discussion For issues that are high-level and not yet ready to implement.

Comments

@keoshi
Copy link
Contributor

keoshi commented Sep 20, 2024

Problem Statement

The current ProgressBar component is quite limited, with no clear sizing or styling options.

As it stands, the bar itself is nearly invisible in certain contexts, making it unsuitable for cases where it needs to stand out. There is also a lack of flexibility for potential use cases other than being used for real-time updates, such as displaying scores or object meters.

image

Goals

  • Explore adding more customization options for size, type, and styling of the ProgressBar, either through props or other means.
  • Consider whether the ProgressBar should remain a single component or be expanded to include labels and indicators for more complex use cases.
  • Discuss the potential use of the component in scenarios beyond simple progress indication, such as denoting a score or other type of permanent status.

Designs

Linear

Link to Figma

image

Circular

Link to Figma

image

Feedback

  1. Should size, type, and styling be customizable through props, or is CSS sufficient for these changes?
  2. Would wrapping progress bar, labels, and indicators into a new component be a better approach for more complex needs?
  3. How do we ensure this component remains simple while still offering flexibility for advanced use cases?

Would love to hear your thoughts @mirka @ciampo @tyxla.

@keoshi keoshi added Needs Design Feedback Needs general design feedback. [Feature] UI Components Impacts or related to the UI component system [Type] Discussion For issues that are high-level and not yet ready to implement. labels Sep 20, 2024
@keoshi keoshi changed the title Components: ProgressBar Components: Expand ProgressBar functionality and visual customization Sep 20, 2024
@mirka
Copy link
Member

mirka commented Sep 24, 2024

  1. Should size, type, and styling be customizable through props, or is CSS sufficient for these changes?

We don't have an official system yet, but from past explorations like the Theme component or the theme package, it's likely that we'll eventually adopt a system based on CSS variables.

  1. Would wrapping progress bar, labels, and indicators into a new component be a better approach for more complex needs?

The suggested patterns look reasonable, but since we don't have actual use cases in the Gutenberg app yet, I don't think we can officially codify them as part of the component yet.

@simison
Copy link
Member

simison commented Oct 8, 2024

A practical example of circular progress indicator that I'd find helpful right away:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Type] Discussion For issues that are high-level and not yet ready to implement.
Projects
None yet
Development

No branches or pull requests

3 participants